Fix Dockerfile templates: add helpers.php #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @williamdes , sorry for his amout of commit, I dont know if its a normal situation. |
Thank you ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have tested the new Dockerfiles and builded multiples images to test the mTLS options,here multiples screens.
I have defined 2 PMA hosts: one without cert and mtls, and the other one with correct configuration. This way I have tested cross configuration files for cross databases auth system (so we can use SSL, mTLS and plain text in the same container).
Firstly, the incorrect configuration:
We can see that MaxScale, configured with mTLS is denying the first auth request. No new feature here.
Now with the correct configruation:
No error on MaxScale size, certs are accepted by MariaDB and PMA is connected and we get SSL/MariaDB server informations. The new feature is working.
But during tests, I seen that the helpers.php was missing in templates and in generated Dockerfiles. So it was not imported during build and base64 vars wans't decoded.
I fixed the problem and now, as far I see, everything is working :)
Tests was done locally, in a Docker SWARM plateform and in K8S.